Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PathFinder.FindPath can return null, Grid.GetPath doesn't handle this resulting in an exception. #15

Closed
Dan-Matt opened this issue Apr 4, 2018 · 4 comments
Labels

Comments

@Dan-Matt
Copy link

Dan-Matt commented Apr 4, 2018

If PathFinder.FindPath returns null, Grid.GetPath doesn't check for it and throws an exception.

@roy-t roy-t added the bug label Apr 4, 2018
@roy-t
Copy link
Owner

roy-t commented Apr 4, 2018

@EnderYoss damn, I somehow deleted that check when moving form v1 to v2. My bad. I'll try to bring out a fix on friday. Thanks so much for the report!

(This is why I should've made unit tests people! :P)

@Dan-Matt
Copy link
Author

Dan-Matt commented Apr 4, 2018

No problem, and yeah you'll have to get some in there! Thanks for the code by the way!

roy-t added a commit that referenced this issue Apr 5, 2018
@roy-t
Copy link
Owner

roy-t commented Apr 5, 2018

I've fixed this in version 2.1.0. It should be indexed by Nuget.org in an hour. I've also added some unit tests to prevent this from happening again. Thanks again for reporting the issue!

@roy-t roy-t closed this as completed Apr 5, 2018
@Dan-Matt
Copy link
Author

Dan-Matt commented Apr 5, 2018

Awesome thanks, no problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants