Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Input Component not holding state #271

Closed
hxltrhuxze opened this issue Sep 11, 2019 · 1 comment
Closed

Text Input Component not holding state #271

hxltrhuxze opened this issue Sep 11, 2019 · 1 comment
Assignees
Labels
Type: Bug Inconsistencies or issues which have caused a problem for users or implementors

Comments

@hxltrhuxze
Copy link
Contributor

Describe the bug
After entering text in the Text Input, the input does not hold its filled state. This causes the label to revert back to its :empty position, clipping the inputted text.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to docs.royalnavy.io/components/forms/input
  2. Click on the Develop Tab
  3. Enter text into input and then click off to remove focus from the input
  4. The label reverts back to its starting position, over the top of the entered text.

Expected behaviour
The label does not revert to its default state.

Screenshots
Screenshot 2019-09-11 at 18 07 24

@antictor
Copy link
Contributor

Most likely the input needs to be put in a formik form in the docs. The field itself is stateless, it's container provides the value as a prop and handle onChange events to that value

@antictor antictor added this to Sprint Backlog in Design System Tactical Board Oct 16, 2019
@antictor antictor moved this from Sprint Backlog to Doing in Design System Tactical Board Oct 17, 2019
@antictor antictor self-assigned this Oct 17, 2019
@antictor antictor mentioned this issue Oct 17, 2019
3 tasks
@antictor antictor moved this from Doing to Done in Design System Tactical Board Oct 17, 2019
@elglup elglup added Type: Bug Inconsistencies or issues which have caused a problem for users or implementors Type: Component and removed bug labels Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Inconsistencies or issues which have caused a problem for users or implementors
Projects
None yet
Development

No branches or pull requests

3 participants