Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Researcher granting write permission #1237

Closed
rpaw053 opened this issue Jan 23, 2017 · 6 comments
Closed

Researcher granting write permission #1237

rpaw053 opened this issue Jan 23, 2017 · 6 comments

Comments

@rpaw053
Copy link
Member

rpaw053 commented Jan 23, 2017

As a Researcher, I want to grant my research organisations a write permission, So that my research organisation can write data to my orcid account

[ORCIDHUB-9] created by rpaw053
@rpaw053
Copy link
Member Author

rpaw053 commented Jan 24, 2017

For this user story, the researcher would be authorized to grant write access to research organisation the important thing we require is client id and client secret code of research organisation(we need to think about how to get client id and secret code for all on boarded organisations).

We are required to write an API that will redirect the researcher to the page which will ask him to grant access to research organisation.

by rpaw053

@rpaw053
Copy link
Member Author

rpaw053 commented Mar 27, 2017

Code changes are done and checked in under branch GH-54_GH-9, Code review, code improvement and unit testing is in progress.

by rpaw053

@rpaw053
Copy link
Member Author

rpaw053 commented Mar 30, 2017

Implementation related to this issue is completed.

by rpaw053

@rpaw053
Copy link
Member Author

rpaw053 commented Apr 2, 2017

Bug/Error:

1/ with only having give a read-limited token, access to the emp/new form is prevented. Expected behaviour
2/ relinking and allowing write access creates the necessary token and gives access to the form but...
3/ when Saving the new employment it fails with the error: "Failed to update the entry: ORCID could not process the data, because they were invalid.. You don't have required permission to edit the record.", suggesting the read-limited token, and not the write token was used.

NB: "You have already given read and write permissions to..."

by jgus614

@rpaw053
Copy link
Member Author

rpaw053 commented Apr 3, 2017

TODO: Bugs fixes:
1) While adding the employment details if user doesn’t not supplies non-compulsory fields such as ‘State/region’, ‘Department’ and ‘Role’, then user gets error “Failure to update %s”.
2) While accessing the employment details page for e.g. https://dev.orcidhub.org.nz/16/emp/new if any admin manually changes the url to https://dev.orcidhub.org.nz/29/emp/new and if there is record present for that url then the Org admin is able to access the link even if he is not the org admin for that record.
3) The created-date and last-modified-date is set to date 1970-01-18, have to fix that.

by rpaw053

@rpaw053
Copy link
Member Author

rpaw053 commented Apr 5, 2017

Bug fix done and the updated code is present on GH-94

by rpaw053

@rpaw053 rpaw053 closed this as completed Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant