Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes impact on Eslint test cases from 2.0 to latest #13

Closed
Teamop opened this issue Feb 3, 2019 · 3 comments
Closed

Changes impact on Eslint test cases from 2.0 to latest #13

Teamop opened this issue Feb 3, 2019 · 3 comments

Comments

@Teamop
Copy link

Teamop commented Feb 3, 2019

  1. Use content checksum instead of mtime and fsize, as @royriojas suggested, this should be optional.
  2. Also the changes above use the fs.readFileSync to replace the fs.statSync
@Teamop Teamop mentioned this issue Feb 3, 2019
Merged
@royriojas
Copy link
Contributor

closed by b0f9ae0

@Teamop
Copy link
Author

Teamop commented Feb 4, 2019

thanks @royriojas , but there's another method file-entry-cache#reconcile still not reverted.

@royriojas
Copy link
Contributor

thanks @Teamop, you were right. Now that is reverted also in version 5.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@royriojas @Teamop