Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update our build system with obs-plugintemplate #357

Merged
merged 47 commits into from Jun 29, 2023

Conversation

umireon
Copy link
Member

@umireon umireon commented Jun 28, 2023

The build system on https://github.com/obsproject/obs-plugintemplate was updated.
It would be great to update our build system also.

@umireon
Copy link
Member Author

umireon commented Jun 28, 2023

I confirmed the notarization works.

Copy link
Collaborator

@royshil royshil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but check out a couple comments

buildspec.json Outdated Show resolved Hide resolved
src/plugin-support.h Show resolved Hide resolved
@umireon
Copy link
Member Author

umireon commented Jun 28, 2023

I have to say that we have to bump OBS dependency to 29+ to adopt the new build system.
The problem that occurs when we use OBS 28.0.1 is not so simple.

@royshil
Copy link
Collaborator

royshil commented Jun 28, 2023

I have to say that we have to bump OBS dependency to 29+ to adopt the new build system. The problem that occurs when we use OBS 28.0.1 is not so simple.

what do you suggest we do?
we update our support to 29.1+?
many users are on 28, especially in Linux

@umireon
Copy link
Member Author

umireon commented Jun 29, 2023

@royshil Finally I have this plugin built with OBS 28.0.1.

@umireon umireon requested a review from royshil June 29, 2023 13:59
Copy link
Collaborator

@royshil royshil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright looking good!

@umireon umireon merged commit c9d8654 into main Jun 29, 2023
6 checks passed
@umireon umireon deleted the umireon.update-build-system branch June 29, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants