New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update our build system with obs-plugintemplate #357
Conversation
…hil/obs-backgroundremoval into umireon.update-build-system
I confirmed the notarization works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but check out a couple comments
I have to say that we have to bump OBS dependency to 29+ to adopt the new build system. |
This reverts commit 5eebf39.
what do you suggest we do? |
@royshil Finally I have this plugin built with OBS 28.0.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright looking good!
The build system on https://github.com/obsproject/obs-plugintemplate was updated.
It would be great to update our build system also.