Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CUSTOM_OPENCV_URL and CUSTOM_OPENCV_HASH for Arch, openSUSE, and Flatpak #425

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

umireon
Copy link
Member

@umireon umireon commented Aug 23, 2023

AUR, Open Build System, and Flatpak do not allow downloading files in CMake.
Adding CUSTOM_OPENCV variables enables these build systems to download dependent OpenCV files by themselves.

@umireon umireon requested a review from royshil August 23, 2023 17:06
@umireon umireon mentioned this pull request Aug 23, 2023
2 tasks
Copy link
Collaborator

@royshil royshil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix and ship!

cmake/FetchOpenCV.cmake Outdated Show resolved Hide resolved
cmake/FetchOpenCV.cmake Outdated Show resolved Hide resolved
@umireon
Copy link
Member Author

umireon commented Aug 23, 2023

I need a new release including this change to ship our latest plugin to AUR, openSUSE, and Flatpak.

@umireon umireon merged commit 2f6f81a into main Aug 23, 2023
6 checks passed
@umireon umireon deleted the umireon.custom-opencv branch August 23, 2023 17:30
@umireon umireon mentioned this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants