Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C17 is only supported CMake 3.21+ #430

Merged
merged 1 commit into from
Aug 27, 2023
Merged

C17 is only supported CMake 3.21+ #430

merged 1 commit into from
Aug 27, 2023

Conversation

umireon
Copy link
Member

@umireon umireon commented Aug 27, 2023

I have a build issue on openSUSE Leap 15.5 that its build system does not support C17.
The CMake provided by openSUSE Leap 15.5 is 3.20 and this version does not understand C17.
https://cmake.org/cmake/help/latest/prop_tgt/C_STANDARD.html
This PR will fix the build on openSUSE Leap.

@umireon umireon requested a review from royshil August 27, 2023 20:06
Copy link
Collaborator

@royshil royshil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@umireon umireon merged commit 053edd0 into main Aug 27, 2023
6 checks passed
@umireon umireon deleted the umireon.fix-c-standard branch August 27, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants