Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook.targets() doesn't handle templates. #9

Closed
roysmith opened this issue Feb 28, 2023 · 1 comment
Closed

Hook.targets() doesn't handle templates. #9

roysmith opened this issue Feb 28, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@roysmith
Copy link
Owner

Hook.targets() should expand templates so things like

'''{{HMS|Melpomene|1794|6}}'''

are handled properly. See 30 December 2019 for an example.

This will require an external call to the parsoid API. The returned HTML may not have the wikilink as a direct child node of the bold tag, so that'll need to be looked at carefully.

@roysmith roysmith added the bug Something isn't working label Feb 28, 2023
@roysmith
Copy link
Owner Author

roysmith commented Mar 7, 2023

Fixed in 61e0b7e

@roysmith roysmith closed this as completed Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant