Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email Sender Identification #21

Closed
sharedphysics opened this issue Sep 8, 2022 · 0 comments
Closed

Email Sender Identification #21

sharedphysics opened this issue Sep 8, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@sharedphysics
Copy link
Collaborator

I received an email from Lurnby the other day that looked like this:
image

Looks like the sender name is coming through as "team" because of "team@lurnby.com" in the Config.py file.

To fix this, you can format the name as Name <email@domain.com>. Reference: https://stackoverflow.com/questions/44385652/add-senders-name-in-the-from-field-of-the-email-in-python

I did this in RecSys and it made my emails more user friendly & better branded.
@sharedphysics sharedphysics added the enhancement New feature or request label Sep 8, 2022
sharedphysics added a commit that referenced this issue Sep 8, 2022
@sharedphysics
Update to Config.py --> Admins sender email.
6548a40 
- This is a fix in response to issue 21: #21
- I have *not* tested the fix locally b/c I don't have a local setup.
- But I did implement this for Recommended Systems and it worked fine. Still, testing recommended.
@sharedphysics sharedphysics mentioned this issue Sep 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sharedphysics