Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple from Amazon #3

Open
Roznoshchik opened this issue Feb 12, 2022 · 1 comment
Open

Decouple from Amazon #3

Roznoshchik opened this issue Feb 12, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@Roznoshchik
Copy link
Owner

For storing image content the app currently sends images to amazon s3. This is fine for the web-app version, but if the app is meant to run locally, then it's not necessary.

There should be a flag somewhere to determine if this is supposed to be a web app or an offline app and removes the Amazon dependency if that's the case.
@Roznoshchik
Copy link
Owner Author

Think this can likely be solved by doing the following.

  1. Adding an env variable such as UPLOAD_IMAGES=1
  2. Keeping the upload to Amazon code behind an if os.environ.get('UPLOAD_IMAGES'):
  3. changing img src to point to the on disk location of the saved images.

@Roznoshchik Roznoshchik added the enhancement New feature or request label Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Roznoshchik