Update to newest version of cortex-m, do a release #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems fine. In general, I don't think it's worth doing a bump on a dependency version that would be picked up according to semantic versioning. If I understand it correct, if we specify 0.7.1, it'll pick up 0.7.3 anyway. We should only increase the number (or specify anything other than x.y.0) if it's strictly required. |
thejpster
approved these changes
Jul 10, 2021
|
Right, I forgot that = is equivalent to ^= in Cargo, and that that will allow 0.8.4 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only functional change in this PR is updating cortex-m
Other than that, just bumping the pac version number and updating release notes.
I wanted to update the build tools (svd2rust, form) but doing so will require some fix-ups on rp-hal at the same time, so it makes sense to depend on a release version first.