Skip to content

Commit

Permalink
Fix: sideEffects; bump some packages and rebuild docs
Browse files Browse the repository at this point in the history
  • Loading branch information
rpearce committed Jan 22, 2020
1 parent f3cae0b commit 6093cf9
Show file tree
Hide file tree
Showing 19 changed files with 890 additions and 838 deletions.
2 changes: 1 addition & 1 deletion .storybook/presets.js
@@ -1 +1 @@
module.exports = ['@storybook/addon-docs/react/preset']
module.exports = ['@storybook/addon-docs/preset']
5 changes: 5 additions & 0 deletions CHANGELOG.md
Expand Up @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [4.0.1] - 2020-01-22

### Fixed
* resolved prod issue where CSS wasn't included in `sideEffects`

## [4.0.0] - 2020-01-19

Complete rewrite with breaking changes so we can move forward with the project.
Expand Down
2 changes: 1 addition & 1 deletion docs/iframe.html
Expand Up @@ -71,4 +71,4 @@
}</script><style>#root[hidden],
#docs-root[hidden] {
display: none !important;
}</style></head><body><div class="sb-nopreview sb-wrapper"><div class="sb-nopreview_main"><h1 class="sb-nopreview_heading sb-heading">No Preview</h1><p>Sorry, but you either have no stories or none are selected somehow.</p><ul><li>Please check the Storybook config.</li><li>Try reloading the page.</li></ul><p>If the problem persists, check the browser console, or the terminal you've run Storybook from.</p></div></div><div class="sb-errordisplay sb-wrapper"><pre id="error-message" class="sb-heading"></pre><pre class="sb-errordisplay_code"><code id="error-stack"></code></pre></div><div id="root"></div><div id="docs-root"></div><script src="runtime~main.9b205d2d8a250f2a35b5.bundle.js"></script><script src="vendors~main.9b205d2d8a250f2a35b5.bundle.js"></script><script src="main.9b205d2d8a250f2a35b5.bundle.js"></script></body></html>
}</style></head><body><div class="sb-nopreview sb-wrapper"><div class="sb-nopreview_main"><h1 class="sb-nopreview_heading sb-heading">No Preview</h1><p>Sorry, but you either have no stories or none are selected somehow.</p><ul><li>Please check the Storybook config.</li><li>Try reloading the page.</li></ul><p>If the problem persists, check the browser console, or the terminal you've run Storybook from.</p></div></div><div class="sb-errordisplay sb-wrapper"><pre id="error-message" class="sb-heading"></pre><pre class="sb-errordisplay_code"><code id="error-stack"></code></pre></div><div id="root"></div><div id="docs-root"></div><script src="runtime~main.8c176336cc151a146c51.bundle.js"></script><script src="vendors~main.8c176336cc151a146c51.bundle.js"></script><script src="main.8c176336cc151a146c51.bundle.js"></script></body></html>
2 changes: 1 addition & 1 deletion docs/index.html
Expand Up @@ -16,4 +16,4 @@
}</script><style>#root[hidden],
#docs-root[hidden] {
display: none !important;
}</style></head><body><div id="root"></div><div id="docs-root"></div><script>window['DOCS_MODE'] = false;</script><script src="runtime~main.6b70b35614cf83eab770.bundle.js"></script><script src="vendors~main.b9320939065af7679d32.bundle.js"></script><script src="main.2fae4beed0f77a55f27c.bundle.js"></script></body></html>
}</style></head><body><div id="root"></div><div id="docs-root"></div><script>window['DOCS_MODE'] = false;</script><script src="runtime~main.6b70b35614cf83eab770.bundle.js"></script><script src="vendors~main.8ec630d0032ffe46e619.bundle.js"></script><script src="main.2fae4beed0f77a55f27c.bundle.js"></script></body></html>

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions docs/main.8c176336cc151a146c51.bundle.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion docs/main.9b205d2d8a250f2a35b5.bundle.js.map

This file was deleted.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions docs/runtime~main.8c176336cc151a146c51.bundle.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion docs/runtime~main.9b205d2d8a250f2a35b5.bundle.js.map

This file was deleted.

2 changes: 1 addition & 1 deletion docs/sb_dll/storybook_ui_dll.js

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions docs/vendors~main.8c176336cc151a146c51.bundle.js

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions docs/vendors~main.8c176336cc151a146c51.bundle.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

3 changes: 0 additions & 3 deletions docs/vendors~main.9b205d2d8a250f2a35b5.bundle.js

This file was deleted.

1 change: 0 additions & 1 deletion docs/vendors~main.9b205d2d8a250f2a35b5.bundle.js.map

This file was deleted.

28 changes: 15 additions & 13 deletions package.json
@@ -1,6 +1,6 @@
{
"name": "react-medium-image-zoom",
"version": "4.0.0",
"version": "4.0.1",
"description": "Accessible medium.com-style image zoom for React",
"main": "dist/cjs/index.js",
"module": "dist/esm/index.js",
Expand Down Expand Up @@ -31,7 +31,9 @@
"modal",
"react-component"
],
"sideEffects": false,
"sideEffects": [
"**/*.css"
],
"files": [
"AUTHORS",
"LICENSE",
Expand Down Expand Up @@ -63,19 +65,19 @@
"@babel/preset-react": "^7.8.3",
"@rollup/plugin-commonjs": "^11.0.1",
"@rollup/plugin-node-resolve": "^7.0.0",
"@storybook/addon-a11y": "^5.3.6",
"@storybook/addon-actions": "^5.3.6",
"@storybook/addon-docs": "^5.3.6",
"@storybook/addon-knobs": "^5.3.6",
"@storybook/addon-links": "^5.3.6",
"@storybook/react": "^5.3.6",
"@storybook/addon-a11y": "^5.3.8",
"@storybook/addon-actions": "^5.3.8",
"@storybook/addon-docs": "^5.3.8",
"@storybook/addon-knobs": "^5.3.8",
"@storybook/addon-links": "^5.3.8",
"@storybook/react": "^5.3.8",
"@testing-library/jest-dom": "^5.0.0",
"@testing-library/react": "^9.4.0",
"all-contributors-cli": "^6.13.0",
"autoprefixer": "^9.7.4",
"axe-core": "^3.4.1",
"babel-core": "^7.0.0-bridge.0",
"babel-jest": "^24.9.0",
"babel-jest": "^25.1.0",
"babel-loader": "^8.0.6",
"babel-plugin-transform-react-remove-prop-types": "^0.4.24",
"coveralls": "^3.0.9",
Expand All @@ -87,15 +89,15 @@
"eslint-plugin-prettier": "^3.1.2",
"eslint-plugin-react": "^7.18.0",
"eslint-plugin-react-hooks": "^2.3.0",
"husky": "^4.0.10",
"husky": "^4.2.0",
"identity-obj-proxy": "^3.0.0",
"jest": "^25.0.0",
"lint-staged": "^10.0.0",
"lint-staged": "^10.0.2",
"npm-run-all": "^4.1.5",
"prettier": "^1.19.1",
"react": "^16.12.0",
"react-dom": "^16.12.0",
"rollup": "^1.29.0",
"rollup": "^1.29.1",
"rollup-plugin-auto-external": "^3.0.0-alpha.0",
"rollup-plugin-babel": "^4.3.3",
"rollup-plugin-postcss": "^2.0.3"
Expand All @@ -106,6 +108,6 @@
},
"dependencies": {
"prop-types": "^15.7.2",
"react-use": "^13.20.0"
"react-use": "^13.21.0"
}
}

0 comments on commit 6093cf9

Please sign in to comment.