api: cleanup dnf.Base.package_remove and make it public api #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 22, 2022 15:44
- Added check for if the package is installed - raise dnf.exceptions.MarkingError is not installed. - added clean_deps flag to goal.erase to handle removal of deps (same as in dnf.Base.remove)
|
Hello Tim and thanks for the contribution! First of all, please drop the formatting changes from the commit as it is very difficult to find the actual mentioned logic changes there. If it is not necessary, please do not include it in the PR or at least put it in the separate commit. We want to have the code formatting consistent across the project codebase. |
|
Looks like vscode, reformatted the code, this was not the plan, I will make a new PR without the code formating |
|
replaced by new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dnfdaemon and yumex-ng uses the dnf.Base.package_remove to mark a installed package for installation, but need workarounds because it don't handle deps in the current state.
And using non public API is not a good thing.