skip_if_unavailable=True fixes #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This paves the way for the following patch.
We're using GKeyFile for parsing .repo files, but the syntax isn't a 100% match. This commit adds a helper to correctly handle "True" and "False" that aren't valid GKeyFile booleans but are valid for .repo files.
|
Can one of the admins verify this patch? |
Conan-Kudo
requested changes
Dec 15, 2016
There was a problem hiding this comment.
I don't think that the rhsm exception should be in here. Please put that into #202 instead with an rhsm/spacewalk plugin.
| } else { | ||
| g_autofree gchar *basename = g_path_get_basename(priv->filename); | ||
| /* special case the satellite and subscription manager repo */ | ||
| if (g_strcmp0(basename, "redhat.repo") == 0) |
There was a problem hiding this comment.
This should be part of a libdnf plugin instead of in libdnf itself, shouldn't it?
There was a problem hiding this comment.
Right, and it can do as a separate PR, but this is just groundwork for an actual crash fix.
Parse the "skip_if_unavailable" key and set the DnfRepo "required" property accordingly.
This ensures that dnf_sack_add_repo() correctly skips skip_if_unavailable repos when the gpg key download fails. https://bugzilla.redhat.com/show_bug.cgi?id=1383819
kalev
force-pushed
the
wip/kalev/bz1383819
branch
from
ccbd2eb
to
6c9efda
Compare
|
These look great! +1 from me. |
|
@dnf-bot r+ |
|
📌 Commit 6c9efda has been approved by |
dnf-bot
pushed a commit
that referenced
this pull request
Dec 15, 2016
We're using GKeyFile for parsing .repo files, but the syntax isn't a 100% match. This commit adds a helper to correctly handle "True" and "False" that aren't valid GKeyFile booleans but are valid for .repo files. Closes: #231 Approved by: hughsie
dnf-bot
pushed a commit
that referenced
this pull request
Dec 15, 2016
Parse the "skip_if_unavailable" key and set the DnfRepo "required" property accordingly. Closes: #231 Approved by: hughsie
dnf-bot
pushed a commit
that referenced
this pull request
Dec 15, 2016
This ensures that dnf_sack_add_repo() correctly skips skip_if_unavailable repos when the gpg key download fails. https://bugzilla.redhat.com/show_bug.cgi?id=1383819 Closes: #231 Approved by: hughsie
|
☀️ Test successful - status-jenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set makes PackageKit work better for repos that have skip_if_unavailable=True set in their .repo files, as is the case for COPR repos. COPR repos are often short lived and as such it's important to correctly handle possible inaccessible repos.
https://bugzilla.redhat.com/show_bug.cgi?id=1383819