Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it do dos2unix cleaning? #260

Closed
guoyunhe opened this issue Oct 2, 2019 · 3 comments
Closed

Does it do dos2unix cleaning? #260

guoyunhe opened this issue Oct 2, 2019 · 3 comments

Comments

@guoyunhe
Copy link

guoyunhe commented Oct 2, 2019

Original issue here openSUSE/osc#647

I sometimes copied some build commands from GitHub or websites. The copied text may contains \r and some editors don't convert it (vim). When I run osc build, it will throw an error at \r position.

@scarabeusiv
Copy link
Contributor

well technically spec-cleaner converts it because it reads all the content and then just adds its own endlines. But feel free to test it if I am not mistaken.

@guoyunhe
Copy link
Author

guoyunhe commented Oct 2, 2019

My test shows different:

echo -e "\r" >> my-package.spec
spec-cleaner my-package.spec
vi my-package.spec

image

@guoyunhe
Copy link
Author

guoyunhe commented Oct 2, 2019

Oops, forgot to add -i option. Then it works. The ending \r or ^M has been removed.

@guoyunhe guoyunhe closed this as completed Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants