-
Notifications
You must be signed in to change notification settings - Fork 44
/
inspect_metadata.c
229 lines (203 loc) · 8.19 KB
/
inspect_metadata.c
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
/*
* Copyright The rpminspect Project Authors
* SPDX-License-Identifier: LGPL-3.0-or-later
*/
#include <stdbool.h>
#include <string.h>
#include <assert.h>
#include "queue.h"
#include "rpminspect.h"
/*
* Validate the metadata tags in the RPM headers.
*/
static bool valid_peers(struct rpminspect *ri, const Header before_hdr, const Header after_hdr)
{
bool ret = true;
bool valid_subdomain = false;
bool rebase = false;
string_entry_t *subdomain = NULL;
const char *after_vendor = NULL;
const char *after_buildhost = NULL;
const char *after_summary = NULL;
const char *after_description = NULL;
const char *after_name = NULL;
char *after_nevra = NULL;
struct result_params params;
assert(ri != NULL);
after_nevra = get_nevra(after_hdr);
rebase = is_rebase(ri);
/* Set up result parameters */
init_result_params(¶ms);
params.header = NAME_METADATA;
after_vendor = headerGetString(after_hdr, RPMTAG_VENDOR);
if (ri->vendor == NULL) {
xasprintf(¶ms.msg, _("Vendor not set in the rpminspect configuration, ignoring Package Vendor \"%s\" in %s"), after_vendor, after_nevra);
params.severity = RESULT_INFO;
params.waiverauth = NOT_WAIVABLE;
params.verb = VERB_OK;
params.noun = NULL;
params.file = NULL;
params.arch = NULL;
params.remedy = get_remedy(REMEDY_VENDOR);
add_result(ri, ¶ms);
free(params.msg);
} else if (after_vendor && strcmp(after_vendor, ri->vendor)) {
xasprintf(¶ms.msg, _("Package Vendor \"%s\" is not \"%s\" in %s"), after_vendor, ri->vendor, after_nevra);
params.severity = RESULT_BAD;
params.waiverauth = NOT_WAIVABLE;
params.verb = VERB_FAILED;
params.noun = _("invalid vendor ${FILE} on ${ARCH}");
params.file = after_vendor;
params.arch = get_rpm_header_arch(after_hdr);
params.remedy = get_remedy(REMEDY_VENDOR);
add_result(ri, ¶ms);
free(params.msg);
ret = false;
}
after_buildhost = headerGetString(after_hdr, RPMTAG_BUILDHOST);
if (after_buildhost && ri->buildhost_subdomain != NULL) {
valid_subdomain = false;
TAILQ_FOREACH(subdomain, ri->buildhost_subdomain, items) {
if (strsuffix(after_buildhost, subdomain->data)) {
valid_subdomain = true;
break;
}
}
if (!valid_subdomain) {
xasprintf(¶ms.msg, _("Package Build Host \"%s\" is not within an expected build host subdomain in %s"), after_buildhost, after_nevra);
params.severity = RESULT_BAD;
params.waiverauth = NOT_WAIVABLE;
params.verb = VERB_FAILED;
params.noun = _("invalid build host ${FILE} on ${ARCH}");
params.file = after_buildhost;
params.arch = get_rpm_header_arch(after_hdr);
params.remedy = get_remedy(REMEDY_BUILDHOST);
add_result(ri, ¶ms);
free(params.msg);
ret = false;
}
}
after_summary = headerGetString(after_hdr, RPMTAG_SUMMARY);
if (after_summary && has_bad_word(after_summary, ri->badwords)) {
xasprintf(¶ms.msg, _("Package Summary contains unprofessional language in %s"), after_nevra);
xasprintf(¶ms.details, _("Summary: %s"), after_summary);
params.severity = RESULT_BAD;
params.waiverauth = NOT_WAIVABLE;
params.verb = VERB_FAILED;
params.noun = _("Summary contains unprofessional words on ${ARCH}");
params.file = NULL;
params.arch = get_rpm_header_arch(after_hdr);
params.remedy = get_remedy(REMEDY_BADWORDS);
add_result(ri, ¶ms);
free(params.msg);
free(params.details);
ret = false;
}
after_description = headerGetString(after_hdr, RPMTAG_DESCRIPTION);
if (after_description && has_bad_word(after_description, ri->badwords)) {
xasprintf(¶ms.msg, _("Package Description contains unprofessional language in %s:"), after_nevra);
xasprintf(¶ms.details, "%s", after_description);
params.severity = RESULT_BAD;
params.waiverauth = NOT_WAIVABLE;
params.verb = VERB_FAILED;
params.noun = _("Description contains unprofessional words on ${ARCH}");
params.file = NULL;
params.arch = get_rpm_header_arch(after_hdr);
params.remedy = get_remedy(REMEDY_BADWORDS);
add_result(ri, ¶ms);
free(params.msg);
free(params.details);
ret = false;
}
free(after_nevra);
if (before_hdr != NULL) {
const char *before_vendor = headerGetString(before_hdr, RPMTAG_VENDOR);
const char *before_summary = headerGetString(before_hdr, RPMTAG_SUMMARY);
const char *before_description = headerGetString(before_hdr, RPMTAG_DESCRIPTION);
after_name = headerGetString(after_hdr, RPMTAG_NAME);
params.msg = NULL;
if (before_vendor == NULL && after_vendor) {
xasprintf(¶ms.msg, _("Gained Package Vendor \"%s\" in %s"), after_vendor, after_name);
} else if (before_vendor && after_vendor == NULL) {
xasprintf(¶ms.msg, _("Lost Package Vendor \"%s\" in %s"), before_vendor, after_name);
} else if (before_vendor && after_vendor && strcmp(before_vendor, after_vendor)) {
xasprintf(¶ms.msg, _("Package Vendor changed from \"%s\" to \"%s\" in %s"), before_vendor, after_vendor, after_name);
}
if (params.msg) {
if (rebase) {
params.severity = RESULT_INFO;
} else {
params.severity = RESULT_VERIFY;
ret = false;
}
params.waiverauth = WAIVABLE_BY_ANYONE;
params.remedy = NULL;
add_result(ri, ¶ms);
free(params.msg);
}
if (before_summary && after_summary && strcmp(before_summary, after_summary)) {
xasprintf(¶ms.msg, _("Package Summary change from \"%s\" to \"%s\" in %s"), before_summary, after_summary, after_name);
params.severity = RESULT_INFO;
params.waiverauth = NOT_WAIVABLE;
params.verb = VERB_OK;
params.noun = NULL;
params.file = NULL;
params.arch = NULL;
params.remedy = NULL;
add_result(ri, ¶ms);
free(params.msg);
}
if (before_description && after_description && strcmp(before_description, after_description)) {
xasprintf(¶ms.msg, _("Package Description changed in %s"), after_name);
xasprintf(¶ms.details, _("from:\n\n%s\n\nto:\n\n%s"), before_description, after_description);
params.severity = RESULT_INFO;
params.waiverauth = NOT_WAIVABLE;
params.verb = VERB_OK;
params.noun = NULL;
params.file = NULL;
params.arch = NULL;
params.remedy = NULL;
add_result(ri, ¶ms);
free(params.msg);
free(params.details);
}
}
return ret;
}
/*
* Main driver for the 'metadata' inspection.
*/
bool inspect_metadata(struct rpminspect *ri)
{
bool good = true;
rpmpeer_entry_t *peer = NULL;
struct result_params params;
assert(ri != NULL);
assert(ri->peers != NULL);
/*
* The metadata inspection looks at the RPM header information and
* performs a few checks:
* - Make sure the Vendor is correct
* - Make sure the Buildhost is in the expected subdomain
* - Check for bad words in the Summary and Description
* - In cases of before and after builds, check for differences
* between the above RPM header values and report them.
*/
TAILQ_FOREACH(peer, ri->peers, items) {
/* Disappearing subpackages are caught by INSPECT_EMPTYRPM */
if (peer->after_rpm == NULL) {
continue;
}
if (!valid_peers(ri, peer->before_hdr, peer->after_hdr)) {
good = false;
}
}
if (good) {
init_result_params(¶ms);
params.severity = RESULT_OK;
params.header = NAME_METADATA;
params.verb = VERB_OK;
add_result(ri, ¶ms);
}
return good;
}