-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] There are manual steps for the "azd pipeline config" #4
Comments
@blow-hey I have updated the GitHub configuration documentation page to clarify the steps to follow for the GitHub configuration. Trying to run again the `` command after finalizing the configuration from GitHub Codespace give me the error below. Do you think I should raise an issue in the Azure/azure-dev repository for this error? |
@blow-hey please let me know if with the latest version of the GitHub configuration documentation page you are able to complete the GitHub configuration and trigger the configured workflow. Thank you in advance for your test. |
We still need to manually trigger the workflow according to the latest version of the GitHub configuration documentation page. |
Hi @blow-hey, I hope you are doing well. I have been able to do a test from a local copy of the repository and I can confirm that it did not trigger the GitHub workflow I configured. But I have also been able to check what the Unfortunately, for the reasons presented below, I don't think I will change the trigger conditions configured in the GitHub workflow of this template repository:
I hope you will understand my position.
|
@rpothin |
@blow-hey thank you for coming back to me regarding this issue. My current hypothesis about this particular point is that Regarding the configuration of the triggers of the GitHub workflow, what do you think about my latest comment? |
@jongio About configuring trigger conditions for GitHub workflows, Rpothin has a different view. But in these templates under |
@v-xuto , there are not guidelines or rules from @rpothin , what's your plan for a flow like:
Are you expecting the first time to be a manual-trigger? or are you waiting until the next commit with changes to run the pipelines? |
Hey @vhvb1989, Thank you for your comment. Your question regarding the flow of work is a really good one.
To be honest with you, I don't really see why I would like to run the GitHub workflow just after its configuration and just after running From my point of view, potential next steps regarding this topic would be:
I hope all this will help you understand my vision on this topic - and I hope you will not find it too different compared to your own vision 😅 Have a great day. |
@vhvb1989 Got it. Because our testing requirements do not require extra manual steps, so we filed this issue. |
@v-xuto , correct. Based on @rpothin 's response, there's no expectation to automatically start the gh-pipeline after |
This is usually a way to delegate But, for now, there's no requirement for azd-templates about how the github or azdo pipelines are expected to work. The template-author can define the |
There are many ways to integrate The model you describe, for instance, provides a unique resource group for each developer and allocates another resource group for QA and for PROD. Another model could be to use two GitHub repos, one for QA/DEV and another for PROD. And there could be another models. Each template can recommend in docs what could be work the best for that template, but it is not a requirement. |
Hi @vhvb1989, Thank you very much for all these details. Currently, and if I am not wrong, the
Have a great day. |
We will close the issue as |
Bug Description
There are manual steps for the
![image](https://user-images.githubusercontent.com/112381413/218428646-3e2a9ae5-2ffb-497c-8d37-02207b348a69.png)
azd pipeline config
, need to manually clickRun workflow
to run theActions
.Steps To Reproduce
1.Login with
az login
andazd login
2.Run Command
azd init --template rpothin/servicebus-csharp-function-dataverse
3.Run Command
.\scripts\post-init-setup.ps1
4.Run Command
azd up
5.Run Command
azd pipeline config --auth-type federated --principal-name <service principal name>
Expected Behavior
azd pipeline config
command should automatically triggerworkflows
for GitHub Actions.@rpothin for notification.
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: