Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto generate jwrapper.xml #54

Closed
cwisniew opened this issue May 13, 2016 · 2 comments
Closed

Auto generate jwrapper.xml #54

cwisniew opened this issue May 13, 2016 · 2 comments
Labels
feature Adding functionality that adds value
Milestone
1.4.2.0

Comments

@cwisniew
Copy link
Member

jwrapper.xml contains hard coded paths and MapTool jar file names (with version number).
This should be generated from the values in gradle properties rather than needing to update the paths in two places and the jar file for each version.
@cwisniew cwisniew added the feature Adding functionality that adds value label May 13, 2016
@cwisniew cwisniew added this to the 1.4.2.0 milestone May 13, 2016
@JamzTheMan
Copy link
Member

Take another look at the gradle tasks. JWrapper.xml is auto generated via gradle using the jwrapper-template.xml as a base. You should NOT be modifying jWrapper.xml or MT.cfg and letting gradle generate those for you. The only thing you need to change is your gradle.properties file.

@cwisniew
Copy link
Member Author

There was a problem in the gradle.build file that was casuing the mt.cfg and the jWrapper.xml file not to be copied from their templates, thus picking up the old one that was there. Fixed now :)

JamzTheMan added a commit that referenced this issue Dec 1, 2018
@JamzTheMan
#54: Missing Preferences menu option on OS X
6f6d410 
 - This hopefully fixes any OSX issues...
   (shamelessly pulled from RPtools 1.4.1-Dev branch)

Task-Url: JamzTheMan#54

Signed-off-by: Jamz <Jamz@Nerps.net>
JamzTheMan added a commit that referenced this issue Dec 1, 2018
@JamzTheMan
#54: Missing Preferences menu option on OS X
8d3e05f 
 - Changelog update.

Task-Url: JamzTheMan#54


Signed-off-by: Jamz <Jamz@Nerps.net>
JamzTheMan added a commit that referenced this issue Dec 1, 2018
@JamzTheMan
#54: Missing Preferences menu option on OS X
07d9c27 
 - Spotless...

Task-Url: JamzTheMan#54

Signed-off-by: Jamz <Jamz@Nerps.net>
JamzTheMan added a commit that referenced this issue Dec 1, 2018
@JamzTheMan
#54: Missing Preferences menu option on OS X
f835424 
 - Edited change log

Task-Url: JamzTheMan#54

Signed-off-by: Jamz <Jamz@Nerps.net>
JamzTheMan added a commit that referenced this issue Dec 1, 2018
@JamzTheMan
1.4.4.2 (#56)
f240462 
* #54: Missing Preferences menu option on OS X

 - This hopefully fixes any OSX issues...
   (shamelessly pulled from RPtools 1.4.1-Dev branch)

Task-Url: JamzTheMan#54

Signed-off-by: Jamz <Jamz@Nerps.net>

* #54: Missing Preferences menu option on OS X

 - Changelog update.

Task-Url: JamzTheMan#54


Signed-off-by: Jamz <Jamz@Nerps.net>

* #54: Missing Preferences menu option on OS X

 - Spotless...

Task-Url: JamzTheMan#54

Signed-off-by: Jamz <Jamz@Nerps.net>

* #54: Missing Preferences menu option on OS X

 - Edited change log

Task-Url: JamzTheMan#54

Signed-off-by: Jamz <Jamz@Nerps.net>
JamzTheMan added a commit that referenced this issue Dec 1, 2018
@JamzTheMan
#54: Missing Preferences menu option on OS X
1083d1c 
 - Oops, forgot to update version #.

Task-Url: JamzTheMan#54

Signed-off-by: Jamz <Jamz@Nerps.net>
JamzTheMan added a commit that referenced this issue Dec 1, 2018
@JamzTheMan
#54: Missing Preferences menu option on OS X
4e4d2a7 
 - Updated changelog

Task-Url: JamzTheMan#54

Signed-off-by: Jamz <Jamz@Nerps.net>
JamzTheMan added a commit that referenced this issue Dec 1, 2018
@JamzTheMan
1.4.4.2 (#57)
dee469b 
* #54: Missing Preferences menu option on OS X

 - This hopefully fixes any OSX issues...
   (shamelessly pulled from RPtools 1.4.1-Dev branch)

Task-Url: JamzTheMan#54

Signed-off-by: Jamz <Jamz@Nerps.net>

* #54: Missing Preferences menu option on OS X

 - Changelog update.

Task-Url: JamzTheMan#54


Signed-off-by: Jamz <Jamz@Nerps.net>

* #54: Missing Preferences menu option on OS X

 - Spotless...

Task-Url: JamzTheMan#54

Signed-off-by: Jamz <Jamz@Nerps.net>

* #54: Missing Preferences menu option on OS X

 - Edited change log

Task-Url: JamzTheMan#54

Signed-off-by: Jamz <Jamz@Nerps.net>

* #54: Missing Preferences menu option on OS X

 - Oops, forgot to update version #.

Task-Url: JamzTheMan#54

Signed-off-by: Jamz <Jamz@Nerps.net>

* #54: Missing Preferences menu option on OS X

 - Updated changelog

Task-Url: JamzTheMan#54

Signed-off-by: Jamz <Jamz@Nerps.net>
JamzTheMan added a commit that referenced this issue Dec 1, 2018
@JamzTheMan
1.4.4.2 (#58)
1ed2f64 
* #54: Missing Preferences menu option on OS X

 - This hopefully fixes any OSX issues...
   (shamelessly pulled from RPtools 1.4.1-Dev branch)

Task-Url: JamzTheMan#54

Signed-off-by: Jamz <Jamz@Nerps.net>

* #54: Missing Preferences menu option on OS X

 - Changelog update.

Task-Url: JamzTheMan#54


Signed-off-by: Jamz <Jamz@Nerps.net>

* #54: Missing Preferences menu option on OS X

 - Spotless...

Task-Url: JamzTheMan#54

Signed-off-by: Jamz <Jamz@Nerps.net>

* #54: Missing Preferences menu option on OS X

 - Edited change log

Task-Url: JamzTheMan#54

Signed-off-by: Jamz <Jamz@Nerps.net>

* #54: Missing Preferences menu option on OS X

 - Oops, forgot to update version #.

Task-Url: JamzTheMan#54

Signed-off-by: Jamz <Jamz@Nerps.net>

* #54: Missing Preferences menu option on OS X

 - Updated changelog

Task-Url: JamzTheMan#54

Signed-off-by: Jamz <Jamz@Nerps.net>

* Bug Fix

 - Fixed AppUpdate to read from manifest under Java 9.
   (Will look for new updates again going forward)

Signed-off-by: Jamz <Jamz@Nerps.net>

* Applied spotless

Signed-off-by: Jamz <Jamz@Nerps.net>
github-merge-queue bot pushed a commit that referenced this issue Apr 25, 2023
@Phergus
Merge pull request #54 from RPTools/develop
0b50460 
Merge develop (release 1.6.4, 1.6.5) back to main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Adding functionality that adds value
Projects
None yet
Milestone
1.4.2.0
Development

No branches or pull requests
2 participants
@cwisniew @JamzTheMan