Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MT crashes on long tooltip #96

Closed
wolph42 opened this issue Jun 17, 2016 · 4 comments
Closed

MT crashes on long tooltip #96

wolph42 opened this issue Jun 17, 2016 · 4 comments
Assignees
Labels

Comments

@wolph42
Copy link

wolph42 commented Jun 17, 2016

When you open the token editor (double click on token), and go to the properties tab and then (accidentily) hover/move mouse over a property that has a really big value (e.g. long json array), MT shows a tooltip with the entire value. However if that value is REALLY big it effectively crashes and you have to terminate MT the hard way.

@Azhrei
Copy link
Member

Azhrei commented Jun 17, 2016

How would you like this solved? If the value really is THAT big, should we truncate it at some point? Should the tooltip panel be as large as possible with scrollbars? (Can scrollbars even be interacted with in a tooltip? I doubt it, since I don't think our tooltips will accept focus.)

@wolph42
Copy link
Author

wolph42 commented Jun 17, 2016

I think that any attempt to show it whole will cause the same crash as its simply too big. So to be save I would opt for truncating it after a certain length.
MT can handle pretty long strings, but e.g. 3000+ character makes it crash (just tried it). So 200 max?

@cwisniew cwisniew added this to the 1.4.3.x Dev Build milestone Jun 25, 2016
@cwisniew cwisniew added the bug label Jun 25, 2016
@Azhrei Azhrei self-assigned this Aug 20, 2016
@Azhrei
Copy link
Member

Azhrei commented Aug 21, 2016

MT is not displaying the tool tip, the JIDE framework is. I've overridden the code that determines what should be displayed for the tool tip on the Properties panel and limited the text to 100 characters plus an ellipsis. I tested it with multiple properties with lengths of at least 200 characters for the values and it looks to be working.

@Azhrei Azhrei mentioned this issue Aug 21, 2016
@wolph42
Copy link
Author

wolph42 commented Aug 21, 2016

Awesome! Can't wait to test. Thnx

@Azhrei Azhrei closed this as completed Aug 28, 2016
cwisniew added a commit to cwisniew/maptool that referenced this issue Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants