rpush_notifications active_record performance improvements #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Change the index on rpush_notifications to minimized number of locked records and pre-sort the records 2. Minimize the locking duration by moving the row dump code outside of the transaction fixes #200
masolin
added a commit
to cardinalblue/rpush
that referenced
this pull request
Jan 28, 2019
v3.1.1 Fixed - Database deadlock [rpush#200](rpush#200) (by [@loadhigh](https://github.com/loadhigh) in [rpush#428](rpush#428)) Enhancements - Change the index on `rpush_notifications` to minimize number of locked records and pre-sort the records ([rpush#428](rpush#428) by [@loadhigh](https://github.com/loadhigh)) - Minimize the locking duration by moving the row dump code outside of the transaction ([rpush#428](rpush#428) by [@loadhigh](https://github.com/loadhigh))
Adrian1707
pushed a commit
to Adrian1707/rpush
that referenced
this pull request
Apr 24, 2024
rpush_notifications active_record performance improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased and updated version of #426. All credit goes to @loadhigh.
Fixes #200