Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for New APNS format #44

Closed
tilo opened this issue May 29, 2014 · 6 comments
Closed

Support for New APNS format #44

tilo opened this issue May 29, 2014 · 6 comments

Comments

@tilo
Copy link

tilo commented May 29, 2014

Looking at ./lib/rpush/client/active_model/apns/notification.rb , it looks like this gem is currently only supporting the LEGACY APNS "Enhanced Noticication Format"
where the notification packet starts with a "1"

see:
https://developer.apple.com/library/ios/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/Chapters/LegacyFormat.html#//apple_ref/doc/uid/TP40008194-CH105-SW1

When are you planning on updating the code to support the newer APNS format starting
with a "2" ?

https://developer.apple.com/library/ios/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/Chapters/CommunicatingWIthAPS.html

@ileitch
Copy link
Member

ileitch commented Jun 3, 2014

Thanks for pointing this out, I wasn't aware of it. I'll take a look soon.

@skunkworker
Copy link
Contributor

Does the current legacy implementation support expiration date and priority setting in the gem?

@skunkworker
Copy link
Contributor

Apparently as well on the new service the payload size has been bumped from 256bytes to 1024 or 2048 (different sizes given at different sessions). Which will help to make it more usable in the future and bring it closer to GCM etc.

@gdeglin
Copy link

gdeglin commented Jul 11, 2014

The notification format rpush currently uses has been bumped up higher than 256 bytes as well. Messages >256bytes work in the sandbox environment. They still fail on the production one though, presumably until iOS8 is officially released.

@ileitch
Copy link
Member

ileitch commented Jul 12, 2014

@skunkworker it does support expiration, which Rpush exposes as the expiry attribute on the Notification. Priority isn't support by version 1.

@ileitch
Copy link
Member

ileitch commented Jul 12, 2014

@gdeglin @skunkworker can you point me in the direction of talk about the increased payload sizes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants