notification_failed not called on APNS error 8

[gdeglin]

If a set of notifications fails to be delivered due to a connection error (For instance, on APNS error code 8), the notification_delivered reflection will still be run for all the notifications and the notification_failed reflection will never be called.

[gdeglin]

This also means that notification_delivered will get called even when the notifications following the failed one did not get delivered. It will get called repeatedly on each retry.

[gdeglin]

We want to keep a counter updated of notifications that have succeeded or failed so we worked around this by adding additional a couple additional reflections.

Since notification_delivered gets called even for notifications that we later discover we need to resend, we added an :apns_need_to_resend reflection to decrement the delivered count when any notifications get queued up again. We also make sure to call the notification_failed reflection when the notification failed (Normally this reflection wants the notification instance to be passed in, but since this value wasn't available in the apns_tcp class we used notification_id instead). Here's the commit: https://github.com/gdeglin/rpush/commit/413ad3fb378496158ed3bfd3e07cfebdd4118cd3

[ileitch]

Thanks for the detailed report. Your commit looks like the right approach, i'll work on merging it (with some minor changes) this weekend.