Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPU type unknown on Ryzen 7 7840U #3715

Closed
silversquirl opened this issue Mar 24, 2024 · 3 comments
Closed

CPU type unknown on Ryzen 7 7840U #3715

silversquirl opened this issue Mar 24, 2024 · 3 comments

Comments

@silversquirl
Copy link

silversquirl commented Mar 24, 2024

Running rr record /bin/echo results in the following error on my laptop:

[FATAL /home/ubuntu/rr/src/PerfCounters_x86.h:121:compute_cpu_microarch()] AMD CPU type 0x70f40 (ext family 0xa) unknown

I'm guessing rr just needs to add this CPU type to allow it to be correctly recognized.

@rocallahan
Copy link
Collaborator

Can you try adding it and running the rr tests? The PR would look something like d9e4547

@yalfg
Copy link

yalfg commented Apr 30, 2024

Can you try adding it and running the rr tests? The PR would look something like d9e4547

Actually the commit you pointed to solves the problem already ;) I have a 7840U laptop too and just tried the current top of tree with this commit, it works.

@silversquirl
Copy link
Author

silversquirl commented May 2, 2024

Seems to be working! I should've tried building from master before reporting this haha. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants