#backtrace_clean_patterns is deprecated

[Ephasme]

Compatibility with rspec-core 2.14.0
Replaced backtrace_clean_patterns by backtrace_exclusion_patterns

[mcmire]

Thanks, but as mentioned in #36 I don't want to outright replace backtrace_clean_patterns with backtrace_exclusion_patterns because it'll make RR break on RSpec 2.13.0 (or maybe not that exactly, but versions before that). I'd rather have something like

patterns =
  if RSpec.configuration.respond_to?(:backtrace_exclusion_patterns)
    RSpec.configuration.backtrace_exclusion_patterns
  else 
    RSpec.configuration.backtrace_clean_patterns
  end

Can you make these changes instead?

[Ephasme]

For sure, I was forgetting backward compatibility.
Do you think I should update the Gemfile too ?

[mcmire]

If you would like, yes. You'll want to update the appraisal gemfiles, though. There are references to rspec ~> 2.13 and also rspec-rails ~> 2.0 in the Appraisals file - update both to ~> 2.14 and then run rake appraisal:install - this willl update relevant lockfiles in gemfiles/ and also ensure that you have rspec 2.14 and rspec-rails 2.14.

[Ephasme]

I will do that this evening.

[janxious]

Any chance of getting a new gem release with this in it?

[mcmire]

Yes, I haven't forgotten. I'll have a new release soon.

[sanemat]

I wait a new release 😌

[mcmire]

Thanks, merged.

[mcmire]

Just released 1.1.2 with this change.

[janxious]

Excellent! Thanks!

[mcmire]

Cool. I put this in the changelog but please note, if you are using

RSpec.configure do |c|
  c.mock_with :rr
end

you will still see a deprecation warning. This is coming from RSpec, not RR, specifically this line: https://github.com/rspec/rspec-core/blob/v2.14.5/lib/rspec/core/mocking/with_rr.rb#L3. This will be fixed in the next release of RSpec, so you can either wait until then, or drop mock_with :rr from your spec_helper.rb (it's basically a no-op as RR has already mixed itself into RSpec by that point).

[pablox-cl]

FWIW; using the latest stable rspec (2.14.7), I'm still seeing the deprecation warning. It looks like on master it's fixed already, but I guess we will have to wait a bit.

[pablox-cl]

Oh, I should add that removing the mock_with :rr, just results in deprecations about that I should use double instead of mock.

(I'm using Padrino 0.12.0)

[mcmire]

Okay, thanks. Out of curiosity what are the deprecations you're seeing from RSpec? Is there a backtrace associated?

[pablox-cl]

Oh, since somewhere along the road rspec changed from mock to double, not requiring rr nor loading with the previous deprecated mock_with :rr, results in rspec trying to use the their own deprecated mock. Is that what you were asking? Or I just misunderstood the question?