Upgrating analyzer version (and fix bugs caused by upgrading)
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Do you mind upgrading the version used in the |
|
Done! Waiting for CI now |
|
Wait a minute, need more changes... |
|
The |
|
Hmmmm... This problem existed before...? Since the current master is "failing" not "passing" https://travis-ci.org/rrousselGit/functional_widget/jobs/651796953#L372 |
|
Indeed, it seems like newer versions introduced a bunch of extra lints. I'll close this PR and fix everything myself |
|
OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mobx.dartrequiresanalyzer: '>=0.38.5 <0.40.0', while this package forces to be lower. Thus, the two cannot be installed without conflict. So I update the version. In addition, there is a bug when updating it, so I also fix two little lines.