Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SingleChildCloneableWidget #37

Closed
simc opened this issue Apr 11, 2019 · 2 comments
Closed

Rename SingleChildCloneableWidget #37

simc opened this issue Apr 11, 2019 · 2 comments

Comments

@simc
Copy link

simc commented Apr 11, 2019

I really like this package. Especially the straightforward naming (coming from scoped_model)

Would it be possible to rename SingleChildCloneableWidget to something like BaseProvider or AbstractProvider to make it more readable?

I suppose most users don't ever use this class but my app is quite complex and I find it very useful...

@rrousselGit
Copy link
Owner

rrousselGit commented Apr 11, 2019

The interface described by SingleChildCloneableWidget is technically unrelated to the notion of "provider" (and so is MultiProvider).
In fact SingleChildCloneableWidgt could even be moved in the Flutter repository (that and a Disposable interface).

So I dislike having "Provider" in the name.

One solution is to rename it on your end, with a subclass (or with typedefs once available):

abstract class BaseProvider implements SingleChildCloneableChild {}

@simc
Copy link
Author

simc commented Apr 11, 2019

Okay thank you 👍

@simc simc closed this as completed Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants