-
Notifications
You must be signed in to change notification settings - Fork 413
/
variable_names.ex
126 lines (100 loc) · 3.2 KB
/
variable_names.ex
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
defmodule Credo.Check.Readability.VariableNames do
use Credo.Check,
base_priority: :high,
explanations: [
check: """
Variable names are always written in snake_case in Elixir.
# snake_case:
incoming_result = handle_incoming_message(message)
# not snake_case
incomingResult = handle_incoming_message(message)
Like all `Readability` issues, this one is not a technical concern.
But you can improve the odds of others reading and liking your code by making
it easier to follow.
"""
]
alias Credo.Code.Name
@special_var_names [:__CALLER__, :__DIR__, :__ENV__, :__MODULE__]
@doc false
@impl true
def run(%SourceFile{} = source_file, params) do
issue_meta = IssueMeta.for(source_file, params)
Credo.Code.prewalk(source_file, &traverse(&1, &2, issue_meta))
end
defp traverse({:=, _meta, [lhs, _rhs]} = ast, issues, issue_meta) do
{ast, issues_for_lhs(lhs, issues, issue_meta)}
end
defp traverse({:->, _meta, [lhs, _rhs]} = ast, issues, issue_meta) do
{ast, issues_for_lhs(lhs, issues, issue_meta)}
end
defp traverse(
{:<-, _meta, [{:|, _comp_meta, [_lhs, rhs]}, _comp_rhs]} = ast,
issues,
issue_meta
) do
{ast, issues_for_lhs(rhs, issues, issue_meta)}
end
defp traverse({:<-, _meta, [lhs, _rhs]} = ast, issues, issue_meta) do
{ast, issues_for_lhs(lhs, issues, issue_meta)}
end
defp traverse(
{:def, _meta, [{_fun, _fun_meta, [lhs, _rhs]}, _fun_rhs]} = ast,
issues,
issue_meta
) do
{ast, issues_for_lhs(lhs, issues, issue_meta)}
end
defp traverse(
{:defp, _meta, [{_fun, _fun_meta, [lhs, _rhs]}, _fun_rhs]} = ast,
issues,
issue_meta
) do
{ast, issues_for_lhs(lhs, issues, issue_meta)}
end
defp traverse(ast, issues, _issue_meta) do
{ast, issues}
end
for op <- [:{}, :%{}, :^, :|, :<>] do
defp issues_for_lhs({unquote(op), _meta, parameters}, issues, issue_meta) do
issues_for_lhs(parameters, issues, issue_meta)
end
end
defp issues_for_lhs({_name, _meta, nil} = value, issues, issue_meta) do
case issue_for_name(value, issue_meta) do
nil ->
issues
new_issue ->
[new_issue | issues]
end
end
defp issues_for_lhs(list, issues, issue_meta) when is_list(list) do
Enum.reduce(list, issues, &issues_for_lhs(&1, &2, issue_meta))
end
defp issues_for_lhs(tuple, issues, issue_meta) when is_tuple(tuple) do
Enum.reduce(
Tuple.to_list(tuple),
issues,
&issues_for_lhs(&1, &2, issue_meta)
)
end
defp issues_for_lhs(_, issues, _issue_meta) do
issues
end
for name <- @special_var_names do
defp issue_for_name({unquote(name), _, nil}, _), do: nil
end
defp issue_for_name({name, meta, nil}, issue_meta) do
string_name = to_string(name)
unless Name.snake_case?(string_name) or Name.no_case?(string_name) do
issue_for(issue_meta, meta[:line], name)
end
end
defp issue_for(issue_meta, line_no, trigger) do
format_issue(
issue_meta,
message: "Variable names should be written in snake_case.",
trigger: trigger,
line_no: line_no
)
end
end