-
Notifications
You must be signed in to change notification settings - Fork 414
/
case_trivial_matches.ex
51 lines (43 loc) · 1.33 KB
/
case_trivial_matches.ex
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
defmodule Credo.Check.Refactor.CaseTrivialMatches do
use Credo.Check,
explanations: [
check: """
PLEASE NOTE: This check is deprecated as it might do more harm than good.
Related discussion: https://github.com/rrrene/credo/issues/65
"""
]
@doc false
@impl true
def run(%SourceFile{} = source_file, params) do
issue_meta = IssueMeta.for(source_file, params)
Credo.Code.prewalk(source_file, &traverse(&1, &2, issue_meta))
end
# TODO: consider for experimental check front-loader (ast)
defp traverse({:case, meta, arguments} = ast, issues, issue_meta) do
cases =
arguments
|> Credo.Code.Block.do_block_for!()
|> List.wrap()
|> Enum.map(&case_statement_for/1)
|> Enum.sort()
if cases == [false, true] do
{ast, issues ++ [issue_for(issue_meta, meta[:line], :cond)]}
else
{ast, issues}
end
end
defp traverse(ast, issues, _issue_meta) do
{ast, issues}
end
defp case_statement_for({:->, _, [[true], _]}), do: true
defp case_statement_for({:->, _, [[false], _]}), do: false
defp case_statement_for(_), do: nil
defp issue_for(issue_meta, line_no, trigger) do
format_issue(
issue_meta,
message: "Case statements should not only contain `true` and `false`.",
trigger: trigger,
line_no: line_no
)
end
end