You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all, hello there and thank you for your outstanding work! You as in @rrrene but also you as in every contributor ever you're amazing and have helped elixir devs all around the world so much! 🎉 🚀 💚
Also github tells me I last contributed in September 2016. Shame on me ;)
Environment
Credo version (mix credo -v): 1.5.6-ref.master.56a77e154+uncommittedchanges
(suspecting if_called_more_often_than to have an impact on time) and well it took 90 seconds. Ran it again with original config and it was 112 seconds. Dunno if this is just normal variance or if there's something to these that impacts it
😱
Anyhow, thanks a lot for everything 💚
The text was updated successfully, but these errors were encountered:
A cursory analysis yielded no obvious performance flaws in the check itself. Maybe it is just a slow check (we have to collect all references to all other modules from every module, after all).
I'll investigate further (any help on this would be appreaciated 👍).
First of all, hello there and thank you for your outstanding work! You as in @rrrene but also you as in every contributor ever you're amazing and have helped elixir devs all around the world so much! 🎉 🚀 💚
Also github tells me I last contributed in September 2016. Shame on me ;)
Environment
mix credo -v
):1.5.6-ref.master.56a77e154+uncommittedchanges
elixir -v
):What were you trying to do?
Activate the AliasUsage lint on our code base with the following configuration:
Expected outcome
It increases the time to analysis the whole code base slightly.
Actual outcome
It 12xs the the code analysis time on the code base.
Deactivating the lint of course solves the problem.
I don't think our configuration has a lot of impact on it, I also tried running it with the "default generated":
and it ended up at 96 seconds & 103 seconds. So, it might be slightly faster but still there is a clear increase.
For fun I tried:
(suspecting
if_called_more_often_than
to have an impact on time) and well it took 90 seconds. Ran it again with original config and it was 112 seconds. Dunno if this is just normal variance or if there's something to these that impacts it😱
Anyhow, thanks a lot for everything 💚
The text was updated successfully, but these errors were encountered: