Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibraryPlaylistCreation - warnings. #17

Closed
raymondwelch33 opened this issue Nov 22, 2022 · 8 comments
Closed

LibraryPlaylistCreation - warnings. #17

raymondwelch33 opened this issue Nov 22, 2022 · 8 comments
Labels
bug Something isn't working high-priority

Comments

@raymondwelch33
Copy link

raymondwelch33 commented Nov 22, 2022

My issue is regarding the two '#TODO' warning notes in the code.

#warning("TODO: ADD RELATIONSHIPS")
#warning("TODO: ADD OPTION TO ADD TRACKS.")

When can we expect relationship and add track to playlist functions in the playlist class?

Thanks!

@rudrankriyam
Copy link
Member

Hi @raymondwelch33! Thank you for using MusadoraKit!

Unfortunately, for playlist one, MusicKit is limiting the development as you cannot get relationships using the Apple Music API. I am thinking of creating a custom structure for it. No ETA, but hopefully should be done soon.

@rudrankriyam rudrankriyam added bug Something isn't working high-priority labels Nov 22, 2022
@rudrankriyam
Copy link
Member

Hi @raymondwelch33.

I've added the option to create a playlist but only with songs at the moment. Let me know if it works for you.

Usage:

let song = try await MusadoraKit.catalogSong(id: "1651994123")
let playlist = try await MusadoraKit.createPlaylist(name: "TESTING SONGS", items: .init(arrayLiteral: song))

@rudrankriyam
Copy link
Member

You can also add music videos to a playlist.

@raymondwelch33
Copy link
Author

Also I notice u change from static to dynamic? Y you do this?

@rudrankriyam
Copy link
Member

Made the package type automatic in Version 1.9.2

@raymondwelch33
Copy link
Author

raymondwelch33 commented Nov 23, 2022

You can also add music videos to a playlist.

How can we achieve ?

@raymondwelch33
Copy link
Author

Can we do this how?

@rudrankriyam
Copy link
Member

Added in Version 1.9.3. See the release notes for usage

https://github.com/rryam/MusadoraKit/releases/tag/v1.9.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority
Projects
None yet
Development

No branches or pull requests

2 participants