Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

Add web API #9

Closed
dvc94ch opened this issue Feb 22, 2019 · 8 comments
Closed

Add web API #9

dvc94ch opened this issue Feb 22, 2019 · 8 comments
Labels
api enhancement New feature or request
Milestone

Comments

@dvc94ch
Copy link
Contributor

dvc94ch commented Feb 22, 2019

We don't have to reimplement a cli since https://github.com/ferristseng/rust-ipfs-api looks nice.

@adamski
Copy link

adamski commented Feb 26, 2019

Are you suggesting using that library to talk to a local node instead of a remote one?

@dvc94ch
Copy link
Contributor Author

dvc94ch commented Feb 26, 2019

It's how the go and js cli interfaces work. You start the daemon and communicate through the http api. The cli talking to the api is already implemented, we just need to implement the other end.

@adamski
Copy link

adamski commented Feb 26, 2019

Ok, so probably using https://hyper.rs? I see that is also used in rust-ipfs-api

@adamski
Copy link

adamski commented Feb 26, 2019

For reference, this looks like the spec that needs implementing: https://ipfs.docs.apiary.io

@gnunicorn
Copy link
Contributor

Ok, so probably using https://hyper.rs? I see that is also used in rust-ipfs-api

Or actix-web. They also have actix-web-support. I personally would prefer us using actix-web-server-side, too.

@dvc94ch
Copy link
Contributor Author

dvc94ch commented Feb 28, 2019

Or tower-rs. But I don't have a strong opinion.

@dvc94ch dvc94ch added enhancement New feature or request api labels Mar 2, 2019
@dvc94ch dvc94ch added this to the mvp milestone Mar 2, 2019
@koivunej
Copy link
Collaborator

warp seems like a good choice for this but may lag behind any tokio 0.2 or std::futures migration. There seems to have been already a gateway server attempt in https://github.com/dvc94ch/rust-ipfs/pull/28 ... I wonder why that one was closed? I understand gateway was probably different from a an http api but the question still stands.

@aphelionz
Copy link
Contributor

Work has begin on this using warp and this ticket might now be duplicated by #60 . Should we close this one for now?

@dvc94ch dvc94ch closed this as completed Mar 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants