UIActivityIndicatorView support #131

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
9 participants

just added suport to UIActivityIndicatorView while image is downloading, if you like to add to the main project, here it is.

rs closed this Nov 4, 2012

Bummer this isn't part of SDWebImage :( Would be very nice to have UIActivityIndicatorViews while images are loading out of the box, rather than adding another external repo or hacking something together.

@ghost

ghost commented May 8, 2013

+1

+1

Hey @MartinHerman ,
you can add this other project to your Podfile: https://github.com/JJSaccolo/UIActivityIndicator-for-SDWebImage

They don't want an activity indicator on the main project.

Collaborator

bpoplauschi commented Sep 12, 2014

Hi guys. Sorry it took so much, but I will reopen the pull request and think about this in the near future. Note: I briefly looked at the implementation from JJSaccolo and I would avoid having another set of setImageWithUrl methods just for the usingActivityIndicatorStyle param. That would make this library even harder to maintain. But maybe we can find some other way

bpoplauschi reopened this Sep 12, 2014

bpoplauschi added this to the 4.0.0 milestone Nov 5, 2014

Create a category is nice idea. :)

mythodeia closed this Sep 29, 2015

@ygweric ygweric pushed a commit to ygweric/SDWebImage that referenced this pull request Mar 2, 2017

@mwaterfall mwaterfall Fixed status bar issue and improved control hiding and showing in iOS 7.
Fixes #131
a597fa7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment