Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed crash on ios7 user device #1584

Merged
merged 1 commit into from Jun 6, 2016
Merged

fixed crash on ios7 user device #1584

merged 1 commit into from Jun 6, 2016

Conversation

minsOne
Copy link
Contributor

@minsOne minsOne commented Jun 5, 2016

fixed crash that string property of NSURLComponents can`t use on iOS7

@minsOne
fixed crash on ios7 user device
335a437 
fixed that string property of NSURLComponents can`t use on iOS7
@bpoplauschi bpoplauschi added this to the 3.8.0 milestone Jun 6, 2016
@bpoplauschi
Copy link
Member

Thanks @minsOne, indeed I missed the min OS of string is 8.0. Related to #1553.

@bpoplauschi bpoplauschi merged commit d8dc6a2 into SDWebImage:master Jun 6, 2016
@bpoplauschi bpoplauschi mentioned this pull request Jun 7, 2016
Closed
bpoplauschi added a commit that referenced this pull request Jun 7, 2016
@bpoplauschi
Reverted all the changes for "Removed the URL query params from the f…
de149ae 
…ilename (key)" fb0cdb6 1bf62d4 #1584 - fixes #1433 #1553 #1583 #1585

This is a deal breaker for people. The solution for those issues (i.e. very long urls) is to set the SDWebImageManager cacheKeyFilter block and do their own calculations there.
@bpoplauschi bpoplauschi mentioned this pull request Jan 30, 2017
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@minsOne @bpoplauschi