Move the imageLoopCount and isAnimated into UIImage+WebCache file, removed the outdated methods #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreampiggy
force-pushed
the
little_refactor_and_deprecate
branch
from
21ee138
to
41cd76b
Compare
dreampiggy
force-pushed
the
little_refactor_and_deprecate
branch
from
41cd76b
to
daecb24
Compare
Codecov Report
@@ Coverage Diff @@
## 5.x #2152 +/- ##
==========================================
+ Coverage 80.53% 80.57% +0.03%
==========================================
Files 36 37 +1
Lines 3586 3588 +2
Branches 320 321 +1
==========================================
+ Hits 2888 2891 +3
+ Misses 675 674 -1
Partials 23 23
Continue to review full report at Codecov.
|
|
This seems not really useful if we want to make it easier to migrate from 4.x to 5.x. So I decide to directly remove that API instead of a deprecation in 4.3.x and removal in 5.x. |
dreampiggy
force-pushed
the
little_refactor_and_deprecate
branch
from
daecb24
to
9f5906e
Compare
dreampiggy
changed the title
Current break change (Need change code)UIImage+MultiFormat.h
UIImage+ForceDecode.h
UIImage+GIF.h
NSImage+WebCache.h
Already Deprecated and RemoveUIImage+WebP.h
SDWebImageDownloaderOperation.h
UIImageView+WebCache.h
|
8 tasks
dreampiggy
force-pushed
the
little_refactor_and_deprecate
branch
from
bedec93
to
1d19e5a
Compare
dreampiggy
commented
Jan 16, 2018
| @@ -37,6 +37,6 @@ typedef NS_ENUM(NSInteger, SDImageFormat) { | |||
| @param format Format as SDImageFormat | |||
| @return The UTType as CFStringRef | |||
| */ | |||
| + (nonnull CFStringRef)sd_UTTypeFromSDImageFormat:(SDImageFormat)format; | |||
| + (nonnull CFStringRef)sd_UTTypeFromSDImageFormat:(SDImageFormat)format CF_RETURNS_NOT_RETAINED; | |||
There was a problem hiding this comment.
This is actually follow the GET rules on Core Foundation, mark this to avoid Swift user use a Unmanaged check
dreampiggy
commented
Jan 16, 2018
| @param image The image to be decompressed | ||
| @return The decompressed image | ||
| */ | ||
| + (nullable UIImage *)sd_decodedImageWithImage:(nullable UIImage *)image; |
There was a problem hiding this comment.
Use category prefix here to avoid name conflict
dreampiggy
commented
Jan 16, 2018
SDWebImage/UIView+WebCache.h
Outdated
| */ | ||
| - (void)sd_setIndicatorStyle:(UIActivityIndicatorViewStyle)style; | ||
| @property (nonatomic, assign) UIActivityIndicatorViewStyle sd_activityIndicatorStyle; |
There was a problem hiding this comment.
These change to make the API more suitable for Swift and Objective-C user. Use method is little wired :)
I'll try to create a new class for indicator. Current design is bad for extension and more flexible
dreampiggy
force-pushed
the
little_refactor_and_deprecate
branch
from
1d19e5a
to
5c164d1
Compare
…moved the outdated methods
… used for a long time
dreampiggy
force-pushed
the
little_refactor_and_deprecate
branch
from
5c164d1
to
1021245
Compare
dreampiggy
force-pushed
the
little_refactor_and_deprecate
branch
from
bac5b1e
to
f1caf8f
Compare
|
Looks good to me. Cheers for better APIs. 🍻 |
…use property based API, which more suitable for Swift
dreampiggy
force-pushed
the
little_refactor_and_deprecate
branch
from
cde5d5f
to
d4daca3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint)This merge request fixes / reffers to the following issues: ...
Pull Request Description
Our current
UIImage+GIFseems out of date. ThatisGIFis not related to GIF image format but whether it's animated. So, instead, I think we should use a more common property to let user know current image is animated.We introduce
sd_isAnimatedto indicate whether the image instance is animated image or not. And also, we previously put those category property anywhere. For example,sd_imageLoopCountis inUIImage+MultiFormat, which should be format related but not image loop count or animated related. So we make it more clear.Attention, that previous
NSImage+WebCachewill resolve a dumplicate symbol because UIImage is defined as NSImage on macOS. SoUIImage+WebCacheshould also be use for NSImage. Therefore, theNSImage+WebCache.hfile should remove that declaration, we seperate the helper method toNSImage+Addtionswhich provide convenience method for cross-platform code.And also, this PR changes some not really good API for Swift with the
NS_SWIFT_NAMEand change some method declaration to property, this can make that more easy to use on Swift.