Expose the read write to FLAnimatedImage associate to the UIImage to allow advanced feature like placeholder #2220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint
)This merge request fixes / reffers to the following issues: #2217
Pull Request Description
In SD 4.3.0. We introduce a way to use associate object to bind
FLAnimatedImage
toUIImage
. This allow user to "store" the FLAnimatedImage into our memory cache and fix some potential issue. At that time I mark this propertyreadonly
because I think user should avoid touching this in most cases.However, some user also argue that they need to set placeholder of a
FLAnimatedImage
instance. SinceFLAnimatedImage
is not aUIImage
subclass, they can not do this. So maybe we should just open this ability to allow write to that associate type. User now just set aFLAnimatedImage
toUIImage
placeholder and all things done.This will not cause API-breaking because
readwrite
is superset ofreadonly
. This is used for advanced feature and user should have the knowledge of what they are doing.