Create a subclass of NSCache using a weak cache. #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreampiggy
force-pushed
the
improvement_weak_cache
branch
2 times, most recently
from
564e6da
to
2107e7e
Compare
…e when memory warning and sync back the alive instance from weak cache into cache.
dreampiggy
force-pushed
the
improvement_weak_cache
branch
from
2107e7e
to
216dfeb
Compare
Codecov Report
@@ Coverage Diff @@
## master #2228 +/- ##
=========================================
- Coverage 78.42% 78.4% -0.02%
=========================================
Files 36 36
Lines 3685 3733 +48
Branches 340 341 +1
=========================================
+ Hits 2890 2927 +37
- Misses 772 783 +11
Partials 23 23
Continue to review full report at Codecov.
|
dreampiggy
commented
Feb 25, 2018
| @@ -26,7 +26,7 @@ - (SDOperationsDictionary *)sd_operationDictionary { | |||
| if (operations) { | |||
| return operations; | |||
| } | |||
| operations = [[NSMapTable alloc] initWithKeyOptions:NSMapTableCopyIn valueOptions:NSMapTableWeakMemory capacity:0]; | |||
There was a problem hiding this comment.
Acutally copy is useless. Because we always pass a immutable NSString but not NSMutableString. Use strong-weak is OK.
|
Nice @dreampiggy |
8 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only remove the cache when memory warning and sync back the alive instance from weak cache into cache.
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint)This merge request fixes / reffers to the following issues: #791 #2227
Pull Request Description
See the description in #791. We can add a weak cache into memory cache for a little performance improvement on iOS/tvOS.
This is useful when the memory warning, the cache was purged. However, the image instance can be retained by other instance such as imageViews and alive. At this case, we can sync weak cache back and do not need to load from disk cache.
For example, you are showing a big imageView with a image, and a tableView contains the thumb image(Through the
UIImageinstance is the same one, only size and scale onUIImageViewdifferent). When memory warning and cache purged, you can also directlly get the image from weak cache without async query disk or re-download.For other normal manually access method such as
removeObjectForKey:,removeAllObjects, we should also remove that weak cache to sync the state.