Add the support for watchOS to use View Category method (sd_setImageWithURL:) on WKInterfaceImage #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithURL:) on WKInterfaceImage
Codecov Report
@@ Coverage Diff @@
## master #2343 +/- ##
==========================================
- Coverage 75.43% 75.22% -0.22%
==========================================
Files 36 36
Lines 3806 3814 +8
==========================================
- Hits 2871 2869 -2
- Misses 935 945 +10
Continue to review full report at Codecov.
|
|
@mythodeia This one again :) |
|
@mythodeia 4.4.0 version released :) Now...Maybe we can focus on 5.x...I'll start to complete the documents for new features. And hope that @bpoplauschi can come back soon. |
|
👍 I am back now, will be picking up the remaining pieces for 5.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint)This merge request fixes / reffers to the following issues: #2331 #1070
Pull Request Description
This PR is cherry-picked from the #2331. Which is already been merged in 5.x branch. However, since this feature is not a API-breaking change, and it's not hard to merge to 4.x as well. So I think we can adopt it to 4.x.
And, after some consideration, I suggest that the next version we can upgrade a minor version, to 4.4.0. Why do so, may because next version we contains 3 feature PR (#2308, #2281 and this one), we also change a little behavior from previous version (#2315), and many historical bugfix. Some changes may not so obvious, but may impact the user usage. So I guess a minor upgrade version should be more acceptable to follow sem-version.