Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace __bridge_transfer with __bridge when convert from CFStringRef to NSString #2394

Merged

Conversation

zhongwuzw
Copy link
Member

@zhongwuzw zhongwuzw commented Jul 18, 2018

New Pull Request Checklist

  • I have read and understood the CONTRIBUTING guide

  • I have read the Documentation

  • I have searched for a similar pull request in the project and found none

  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

  • I have added the required tests to prove the fix/feature I am adding

  • I have updated the documentation (if necessary)

  • I have run the tests and they pass

  • I have run the lint and it passes (pod lib lint)

This merge request fixes / reffers to the following issues: ...

Pull Request Description

The same as #2392 .

@bpoplauschi bpoplauschi added this to the 4.4.2 milestone Jul 18, 2018
@zhongwuzw zhongwuzw added the fix label Jul 18, 2018
@bpoplauschi bpoplauschi merged commit d7c6650 into SDWebImage:master Jul 18, 2018
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@98a2d9a). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2394   +/-   ##
=========================================
  Coverage          ?   75.16%           
=========================================
  Files             ?       36           
  Lines             ?     3894           
  Branches          ?        0           
=========================================
  Hits              ?     2927           
  Misses            ?      967           
  Partials          ?        0
Impacted Files Coverage Δ
SDWebImage/SDWebImageCoderHelper.m 61.59% <ø> (ø)
SDWebImage/SDWebImageGIFCoder.m 79.8% <100%> (ø)
SDWebImage/SDWebImageImageIOCoder.m 81.61% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98a2d9a...61800a8. Read the comment docs.

@zhongwuzw zhongwuzw deleted the fix-cfstringref-ownership-for-master branch July 18, 2018 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants