Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AllowCredentials should be true in AllowAll() #98

Closed
mcluseau opened this issue Apr 30, 2020 · 1 comment
Closed

AllowCredentials should be true in AllowAll() #98

mcluseau opened this issue Apr 30, 2020 · 1 comment

Comments

@mcluseau
Copy link

Hi, thanks for this great module :-)

I think there a mismatch at least with the godoc about AllowCredentials, I think it should be true here: https://github.com/rs/cors/blob/master/cors.go#L196
@ishveda
Copy link

ishveda commented Aug 4, 2020

It is not allowed to have AllowedOrigins set to * with AllowCredentials set to true at the same time.

@rs rs closed this as completed Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rs @mcluseau @ishveda