New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace BulmUtils toasts with toastResponses #108

Closed

rsalesc opened this issue Aug 17, 2018 · 1 comment

Milestone

Owner

rsalesc commented Aug 17, 2018

toastResponses() should be responsible for handling the following before showing an appropriate error message.

If the user is an admin or a contestant.
If the returned message is a validation error.
If the returned message is an internal error.
Otherwise it is just a raw message that should be shown.

Currently, toasted messages are really ugly and non-intuitive in certain cases.

rsalesc mentioned this issue

Properly show Mongoose validation errors #100

Closed

rsalesc added this to the Regionals milestone

Owner Author

rsalesc commented Oct 9, 2018 •

edited

Loading

Addressed by 7bddf42, which further removes BulmUtils entirely.

rsalesc closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment