Added iOS 8 support for location service requests #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 2, 2014 11:07
…is necessary to support location services on iOS 8
… within the completion block of location permission requests
|
+1 |
1 similar comment
|
+1 |
rsattar
added a commit
that referenced
this pull request
Sep 26, 2014
Added iOS 8 support for location service requests
|
Sorry it took so long to review this, this is great! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
according to Apples documentation of CLLocationManager (https://developer.apple.com/library/prerelease/ios/documentation/CoreLocation/Reference/CLLocationManager_Class/index.html#//apple_ref/occ/instm/CLLocationManager/) it is required to call either
requestWhenInUseAuthorizationorrequestAlwaysAuthorizationon a CLLocationManager before you start updating the location under iOS 8.It is also necessary to define - depending on the chosen authorization type - either
NSLocationWhenInUseUsageDescriptionorNSLocationAlwaysUsageDescriptionin the projectsInfo.plist.I have added an enum
ClusterLocationAuthorizationTypeas well as a new method to request the permissions for a specific authorization type. Backwards compatiblity is maintained by letting the former method definition chooseClusterLocationAuthorizationTypeAlwaysby default.Cheers,
Tom