Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rf: review use of types.Info #7

Open
mdempsky opened this issue Dec 7, 2020 · 0 comments
Open

rf: review use of types.Info #7

mdempsky opened this issue Dec 7, 2020 · 0 comments

Comments

@mdempsky
Copy link
Collaborator

mdempsky commented Dec 7, 2020

The fix in 71eddf1 was due to using the wrong package's types.Info, so it was missing information for non-exported declarations. I had used "info" because I saw it used for similar code elsewhere in that function, so I thought it was safe to use.

It would be good to double check the other cases, and write tests cases for any that are incorrect. I suspect some may work today only because many tests only use a single package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdempsky