Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlights stretching accross a line end not found #7

Open
widle opened this issue Jul 25, 2012 · 4 comments
Open

highlights stretching accross a line end not found #7

widle opened this issue Jul 25, 2012 · 4 comments

Comments

@widle
Copy link

widle commented Jul 25, 2012

Exporting highlights and associated notes works only as long as the highlight stays on a single line of text. When the highlight is longer, it is not found and the note is attached to one corner of the page with a corresponding error text.

If I understand things right, this is going to be addressed by Issue #4, but I'm filing it as a separate issue anyway, just in case.

@rschroll
Copy link
Owner

Sorry to hear this. I've had some success with multiline highlights, but I'm not surprised to hear that this part of the code is fragile. You're right -- a fix to #4 should solve this problem. But there are other mitigations we might make to help here, so I'm going to leave this open in case #4 isn't fixed soon.

@rschroll
Copy link
Owner

I've just pushed a change that might help in this case. If you get a chance, could you try it out and let me know if it help or not?

Unfortunately, the solution to #4 is looking harder and harder....

@widle
Copy link
Author

widle commented Jan 30, 2013

I'm sorry it took me so long to answer. The truth is, it didn't help, the long highlights stil aren't found on the page. I usually create my PDF files from text editors like Word by "printing" or saving as PDF, if that helps.

@rschroll
Copy link
Owner

That's too bad. I haven't looked at #4 recently, but last time I did, I
was getting very confused. So I can't promise any timescale for a fix
there.

If you send me an offending PDF (rschroll at gmail), I'll take a look
and see if there's an easy work-around for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants