Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During initialization of
DocumentPage
instances, a bug caused rmrl to always render the template of the notebook's last page. The bugfix is trivial since this was only a mix-up (max
instead ofmin
).For more context (if needed) - consider the inline documentation prior to the culprit line:
rmrl/rmrl/document.py
Lines 60 to 64 in 89b5cc3
In such cases,
len(template_names)
would be less thanself.num
. Access withmax
would then raise anIndexError
.For all other exports (where
self.num
is always less thanlen(template_names)
), this line will always select the last entry withintemplate_names
.