New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MappingSchema.TryGetConvertExpression returns null instead of bool #48

Closed

NN--- opened this issue Oct 24, 2018 · 1 comment

Member

NN--- commented Oct 24, 2018

This should not be called TryGet** or return bool.

protected internal virtual LambdaExpression TryGetConvertExpression(Type from, Type to)
		{
			var li = GetConverter(from, to, false);
			return li == null ? null : (LambdaExpression)ReduceDefaultValue(li.CheckNullLambda);
		}

NN--- mentioned this issue

Add code annotations. #44

Merged

Member Author

NN--- commented Dec 4, 2018

Discussed that Try** are allowed to return null.

NN--- closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment