Load LLVM for clang containers.

[mdavis36]

When using clang compilers you need to load LLVM before running codes built with omp support. It would be nice if LLVM pre-loaded in the containers.

[vsoch]

We could definitely try that! @trws @davidbeckingsale what would that look like w.r.t spack?

[davidbeckingsale]

I think we could do it in the base images making sure LD_LIBRARY_PATH is set up correctly to pick up what's added to the view, extending what's done here: https://github.com/rse-ops/docker-images/blob/main/ubuntu/22.04/Dockerfile#L11

[trws]

Yeah, I had intended that to work based on those changes, must be something missing.

[trws]

Rather these changes:

docker-images/scripts/set-up-spack.sh

Line 37 in 1e2bb6a

echo /opt/view/lib > /etc/ld.so.conf.d/spack_view.conf

What directory is missing from the library search? We should add something to the clang file that adds it to the load cache, that'll be more robust than the environment variable or loading would be.

[trws]

Found the bug, we were only getting lib64 in the search path instead of both lib and lib64, fix is coming shortly.

[mdavis36]

@vsoch @trws This issue has popped up for us again, we are having to manually add /opt/view/lib to LD_LIBRARY_PATH for our clang image builds.

[trws]

In what image/context? The path should always be there now, it's still added to ld.so.conf and reconfigured, so something funny must be happening.

[vsoch]

Could you link the image? it could be an old one - I was perusing this weekend and we still have some old images in the UI (and perhaps we should remove).

[mdavis36]

We were seeing this using the below images as our base image:

ghcr.io/rse-ops/clang-ubuntu-20.04:llvm-11.0.0
ghcr.io/rse-ops/clang-ubuntu-22.04:llvm-13.0.0

I fixed it in this PR LLNL/RAJA#1301

[vsoch]

@trws it looks like we do ldconfig in our base image, should we try adding it in the images referenced as a final command?

https://github.com/rse-ops/docker-images/blob/cd590b3e95b0489eef14fe14069f601497607323/scripts/set-up-spack.sh

[trws]

We could, but if ldconfig has run, it shouldn't need to be run again unless the new file is removed and ldconfig is run again. Not sure what would be causing a problem with it.

[vsoch]

Could we just add to LD_LIBRARY_PATH too then?

[trws]

I don’t see any harm in that, should just be redundant but if it helps then great!

…

--- Sent from Workspace ONE Boxer<https://whatisworkspaceone.com/boxer> On August 16, 2022 at 8:55:05 PM PDT, Vanessasaurus ***@***.***> wrote: Could we just add to LD_LIBRARY_PATH too then? — Reply to this email directly, view it on GitHub<https://urldefense.us/v3/__https://github.com/rse-ops/docker-images/issues/85*issuecomment-1217431678__;Iw!!G2kpM7uM-TzIFchu!kBfSr8MlbpbLACM7DzZwgCyiWD6YTm3jWG15q53PRGieE6eZzXJSlj8zyNp7pKVWGA$>, or unsubscribe<https://urldefense.us/v3/__https://github.com/notifications/unsubscribe-auth/AAFBFNJIPTS4HIZYWOX6MVLVZRPBHANCNFSM5QWFJCJA__;!!G2kpM7uM-TzIFchu!kBfSr8MlbpbLACM7DzZwgCyiWD6YTm3jWG15q53PRGieE6eZzXJSlj8zyNrS0RJX0w$>. You are receiving this because you were mentioned.Message ID: ***@***.***>