Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include deps in views, ignore conflicts #34

Merged
merged 2 commits into from
Sep 23, 2021
Merged

Don't include deps in views, ignore conflicts #34

merged 2 commits into from
Sep 23, 2021

Conversation

davidbeckingsale
Copy link
Collaborator

No description provided.

@davidbeckingsale
Copy link
Collaborator Author

Our view updates were failing due to conflicts. This PR restricts what gets included, and also adds the -i flag to ignore conflicts in case they do occur.

Copy link
Contributor

@vsoch vsoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! My only suggestion would be to use the full flag name (if there is one) so a future reader not familiar with spack can more easily understand.

@davidbeckingsale
Copy link
Collaborator Author

This looks good! My only suggestion would be to use the full flag name (if there is one) so a future reader not familiar with spack can more easily understand.

Good idea, will fix.

@vsoch
Copy link
Contributor

vsoch commented Sep 23, 2021

That's now perfect! I'll watch this and merge when all builds pass (relevant to the changes)

@vsoch vsoch merged commit 467a6d7 into main Sep 23, 2021
@vsoch vsoch deleted the bugfix/views branch September 23, 2021 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants