Skip GenericForeignKey fields #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmbouter
force-pushed
the
allow-use-with-generic-foreign-key
branch
from
d49cc5e
to
157c6f1
Compare
|
@rsinger86 what do you think about this? Can we do any better in this case? |
The `GenericForeignKey` field does not provide a `get_internal_type` method so when checking if it's a ForeignKey or not an AttributeError is raised. This adjusts the code to ignore this `AttributeError` which effectively un-monitors the `GenericForeignKey` itself. However, it does leave the underlying `ForeignKey` to the `ContentType` table and the primary key storage field indexing into that table monitored. This does not enable support for hooking on the name of the `GenericForeignKey`, but hooking on the underlying fields that support that `GenericForeignKey` should still be possible. closes rsinger86#42
bmbouter
force-pushed
the
allow-use-with-generic-foreign-key
branch
from
157c6f1
to
8a9fead
Compare
|
These are all passing in the CI of my fork: https://travis-ci.com/github/bmbouter/django-lifecycle/builds/178427056 |
|
@rsinger86 I've just learned that I can't have our project use my fork of |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GenericForeignKeyfield does not provide aget_internal_typemethod so when checking if it's a ForeignKey or not an AttributeError is
raised.
This adjusts the code to ignore this
AttributeErrorwhich effectivelyun-monitors the
GenericForeignKeyitself. However, it does leave theunderlying
ForeignKeyto theContentTypetable and the primary keystorage field indexing into that table monitored. This does not enable
support for hooking on the name of the
GenericForeignKey, but hookingon the underlying fields that support that
GenericForeignKeyshouldstill be possible.
closes #42