Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run hooks within a single transaction #85

Closed
lostb1t opened this issue Oct 18, 2021 · 1 comment · Fixed by #86
Closed

Run hooks within a single transaction #85

lostb1t opened this issue Oct 18, 2021 · 1 comment · Fixed by #86

Comments

@lostb1t
Copy link

lostb1t commented Oct 18, 2021 •
edited
Loading

Django save signals are run within the same transaction. So if something goes wrong in post_save for example the instance is never saved als the transaction is rolled back. Would be nice to have the same behavior for lifecycle hooks
@amirmotlagh amirmotlagh mentioned this issue Oct 23, 2021
Merged
@rsinger86
Copy link
Owner

yeah, good call. much appreciated. will merge in soon.

@amcclosky amcclosky mentioned this issue Jan 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move save() and delete() functions into transaction amirmotlagh/django-lifecycle
2 participants
@lostb1t @rsinger86