Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping "Temperature" to first slider (CC:0) doesn't work #34

Closed
neilpho opened this issue Oct 22, 2015 · 5 comments
Closed

Mapping "Temperature" to first slider (CC:0) doesn't work #34

neilpho opened this issue Oct 22, 2015 · 5 comments

Comments

@neilpho
Copy link

neilpho commented Oct 22, 2015

I've mapped the 8 sliders of my nanoKontrol2 to the 1st 8 basic controls of Lightroom CC 2015.1. They all work as expected except for colour temperature. It's not possible to "pick up" the thumb of this slider unless it is at the lower end of the scale. Then is is only possible to move the slider downwards so the image ends up stuck with a blue cast.

@rsjaffe
Copy link
Owner

rsjaffe commented Oct 22, 2015

Please try assigning temperature to one of the other sliders to see if the problem is related to that slider or not. Thanks.

@neilpho
Copy link
Author

neilpho commented Oct 22, 2015

Good idea. I tried another slider and a knob and the problem is related to temperature rather than the control used.

@rsjaffe
Copy link
Owner

rsjaffe commented Oct 22, 2015

Hmm. Could you try the following?

In the plugin's directory, open up the file MIDI2LR_Client.lua in a plain text editor like notepad. Around 30 lines down, you'll find the following code:

local function midi_lerp_to_develop(param, midi_value)
    -- map midi range to develop parameter range
    local min,max = LrDevelopController.getRange(param)
    if(param == 'Temperature' and max > 8000) then
        min = 2000
        max = 8000
    end

    local result = midi_value/127 * (max-min) + min
    return result
end

Edit the line

if(param == 'Temperature' and max > 8000) then

to read

if(param == 'Temperature') then

Save the modified file, then, in lightroom, open up the plug-in manager (file->plugin manager), select the MIDI2LR plugin and press the button to reload the plugin. Or you could just restart LR. Then see if that fixed the issue.

If that didn't fix the issue, edit the lua file to remove the range control for temperature by deleting the following lines, then test as above.

    if(param == 'Temperature' and max > 8000) then
        min = 2000
        max = 8000
    end

@Der-Canonier
Copy link

The error occurs with me also. Both solutions are not working. The temperature will be provided by 5250 to 4409 and then to 3559, then nothing happens. Increasing the temperature does not work

@rsjaffe
Copy link
Owner

rsjaffe commented Oct 25, 2015

I'm reverting the change that was made to the temperature range control. Will see this change in the next release.

Reverted commit 31c029c in commit d24f025 .

@rsjaffe rsjaffe closed this as completed Oct 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants